Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 996433002: run_tests.py: find test executables in an in-Chromium build (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M build/run_tests.py View 1 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-09 19:39:58 UTC) #2
scottmg
lgtm https://codereview.chromium.org/996433002/diff/1/build/run_tests.py File build/run_tests.py (right): https://codereview.chromium.org/996433002/diff/1/build/run_tests.py#newcode34 build/run_tests.py:34: binary_dir = os.path.join(crashpad_dir, 'out') I think calling binary_dir ...
5 years, 9 months ago (2015-03-09 19:59:59 UTC) #3
Mark Mentovai
https://codereview.chromium.org/996433002/diff/1/build/run_tests.py File build/run_tests.py (right): https://codereview.chromium.org/996433002/diff/1/build/run_tests.py#newcode34 build/run_tests.py:34: binary_dir = os.path.join(crashpad_dir, 'out') scottmg wrote: > I think ...
5 years, 9 months ago (2015-03-09 20:14:38 UTC) #4
Mark Mentovai
5 years, 9 months ago (2015-03-09 20:14:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e1df1599e15789da53af2494b4bf4d6f459c762d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698