Issue 996363002: Add isDeleted flag to ServiceWorkerRegistration DevTool's protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 996363002: Add isDeleted flag to ServiceWorkerRegistration DevTool's protocol. (Closed)

Created:
5 years, 9 months ago by horo

Modified:
5 years, 9 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Add isDeleted flag to ServiceWorkerRegistration in DevTool's protocol. We shuold show the registrations which are already deleted from the storage but are still exist in the memory. This could happen when ServiceWorkerRegistration.unregister() has been called but there are still some controlled pages. I will remove workerRegistrationDeleted event after chromium side patch (https://codereview.chromium.org/998173002/) will be landed. BUG=463892 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191776

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	Source/devtools/protocol.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996363002/1

5 years, 9 months ago (2015-03-12 13:08:41 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-12 14:31:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191776

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages