Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9963133: Omnibox Example extension tries to load .html instead of .js. (Closed)

Created:
8 years, 8 months ago by chebert
Modified:
8 years, 8 months ago
Reviewers:
cduvall, aa.chromium
CC:
chromium-reviews, mihaip+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Omnibox Example extension tries to load .html instead of .js. BUG=121789 TEST=Load Omnibox Example extension. Notice it works now. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131290

Patch Set 1 #

Total comments: 1

Patch Set 2 : Small changes. #

Patch Set 3 : Re-uploading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/common/extensions/docs/examples/api/omnibox/simple-example.zip View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/omnibox/simple-example/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
chebert
https://chromiumcodereview.appspot.com/9963133/diff/1/chrome/common/extensions/docs/examples/api/omnibox/simple-example.zip File chrome/common/extensions/docs/examples/api/omnibox/simple-example.zip (right): https://chromiumcodereview.appspot.com/9963133/diff/1/chrome/common/extensions/docs/examples/api/omnibox/simple-example.zip#newcode29 chrome/common/extensions/docs/examples/api/omnibox/simple-example.zip:29: "scripts": ["background.html"] Shouldn't this have changed when I ran ...
8 years, 8 months ago (2012-04-03 23:26:58 UTC) #1
chebert
On 2012/04/03 23:26:58, chebert wrote: > https://chromiumcodereview.appspot.com/9963133/diff/1/chrome/common/extensions/docs/examples/api/omnibox/simple-example.zip > File chrome/common/extensions/docs/examples/api/omnibox/simple-example.zip > (right): > > https://chromiumcodereview.appspot.com/9963133/diff/1/chrome/common/extensions/docs/examples/api/omnibox/simple-example.zip#newcode29 ...
8 years, 8 months ago (2012-04-03 23:41:23 UTC) #2
Aaron Boodman
LGTM I wouldn't worry about it. I don't think Rietveld/GCL is very good at binary ...
8 years, 8 months ago (2012-04-07 00:49:15 UTC) #3
Aaron Boodman
You can double-check though one your change lands.
8 years, 8 months ago (2012-04-07 00:49:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/9963133/2003
8 years, 8 months ago (2012-04-07 00:52:37 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/common/extensions/docs/samples.json. While running patch -p1 --forward --force; patching file chrome/common/extensions/docs/samples.json ...
8 years, 8 months ago (2012-04-07 00:52:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/9963133/8001
8 years, 8 months ago (2012-04-07 18:58:40 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-07 21:00:46 UTC) #8 
Change committed as 131290

Powered by Google App Engine
This is Rietveld 408576698