Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 996313002: Serve fast NTP when experiment is enabled (Closed)

Created:
5 years, 9 months ago by fserb
Modified:
5 years, 9 months ago
Reviewers:
*Mathieu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Serve fast NTP when experiment is enabled BUG=461032 Committed: https://crrev.com/5623c836dafbf8eb85cc9a41c074bbfd8514ad53 Cr-Commit-Position: refs/heads/master@{#320949}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M chrome/browser/search/local_ntp_source.cc View 1 4 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
fserb
5 years, 9 months ago (2015-03-11 19:12:36 UTC) #3
Mathieu
https://codereview.chromium.org/996313002/diff/1/chrome/browser/search/local_ntp_source.cc File chrome/browser/search/local_ntp_source.cc (right): https://codereview.chromium.org/996313002/diff/1/chrome/browser/search/local_ntp_source.cc#newcode82 chrome/browser/search/local_ntp_source.cc:82: bool IsLocalNTPFastEnabled() { Can you 1-line comment these functions? ...
5 years, 9 months ago (2015-03-14 19:58:27 UTC) #4
fserb
https://codereview.chromium.org/996313002/diff/1/chrome/browser/search/local_ntp_source.cc File chrome/browser/search/local_ntp_source.cc (right): https://codereview.chromium.org/996313002/diff/1/chrome/browser/search/local_ntp_source.cc#newcode82 chrome/browser/search/local_ntp_source.cc:82: bool IsLocalNTPFastEnabled() { On 2015/03/14 19:58:27, Mathieu Perreault wrote: ...
5 years, 9 months ago (2015-03-16 19:52:27 UTC) #5
Mathieu
5 years, 9 months ago (2015-03-17 17:06:05 UTC) #6
Mathieu
lgtm
5 years, 9 months ago (2015-03-17 17:06:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996313002/20001
5 years, 9 months ago (2015-03-17 18:04:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 18:56:26 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:57:19 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5623c836dafbf8eb85cc9a41c074bbfd8514ad53
Cr-Commit-Position: refs/heads/master@{#320949}

Powered by Google App Engine
This is Rietveld 408576698