Don't generate forwarding hooks if all noSuchMethod implementations

pkg/compiler/lib/src/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
@@ skipping 344 matching lines @@
 
   /// Call this to register that a static function has been closurized.
   void registerGetOfStaticFunction(Enqueuer enqueuer) {}
 
   /**
    * Call this to register that the [:runtimeType:] property has been accessed.
    */
   void registerRuntimeType(Enqueuer enqueuer, Registry registry) {}
 
   /**
+   * Call this to register a `noSuchMethod` implementation.
+   */
+  void registerNoSuchMethod(Element noSuchMethodElement, Enqueuer enqueuer) {

[Johnni Winther, 2015/03/16 14:20:43]

Leave the default implementation empty. Only the JS backend cares about this.

[Harry Terkelsen, 2015/03/17 21:43:11]

Done.

+    if (compiler.enabledNoSuchMethod) return;
+    if (isDefaultNoSuchMethodImplementation(noSuchMethodElement)) return;
+    enableNoSuchMethod(enqueuer);
+    compiler.enabledNoSuchMethod = true;

[floitsch, 2015/03/13 15:51:49]

I would have expected this to be in `enableNoSuchMethod`.

What's the semantics of "Compiler.enabledNoSuchMethod" ?
Could we keep it in the backend?

[Johnni Winther, 2015/03/16 14:20:43]

Add a TODO on Compiler.enabledNoSuchMethod to move it to the JS backend.

[Harry Terkelsen, 2015/03/17 21:43:11]

It is just a flag that says if noSuchMethod support is enabled. It is only used
by the JS backend. I moved the flag to the backend

[Harry Terkelsen, 2015/03/17 21:43:11]

I just moved it

+  }
+
+  /**
    * Call this method to enable [noSuchMethod] handling in the
    * backend.
    */
-  void enableNoSuchMethod(Element context, Enqueuer enqueuer) {
+  void enableNoSuchMethod(Enqueuer enqueuer) {

[floitsch, 2015/03/13 15:51:49]

Can we remove this method? (or make it private)

[Harry Terkelsen, 2015/03/17 21:43:11]

Done.

     enqueuer.registerInvocation(compiler.noSuchMethodSelector);
   }
 
   /// Call this method to enable support for isolates.
   void enableIsolateSupport(Enqueuer enqueuer) {}
 
   void registerRequiredType(DartType type, Element enclosingElement) {}
   void registerClassUsingVariableExpression(ClassElement cls) {}
 
   void registerConstSymbol(String name, Registry registry) {}
@@ skipping 1241 matching lines @@
 
     if (stopAfterTypeInference) return;
 
     log('Compiling...');
     phase = PHASE_COMPILING;
     // TODO(johnniwinther): Move these to [CodegenEnqueuer].
     if (hasIsolateSupport) {
       backend.enableIsolateSupport(enqueuer.codegen);
     }
     if (enabledNoSuchMethod) {
-      backend.enableNoSuchMethod(null, enqueuer.codegen);
+      backend.enableNoSuchMethod(enqueuer.codegen);
     }
     if (compileAll) {
       libraryLoader.libraries.forEach((LibraryElement library) {
         fullyEnqueueLibrary(library, enqueuer.codegen);
       });
     }
     processQueue(enqueuer.codegen, mainFunction);
     enqueuer.codegen.logSummary(log);
 
     int programSize = backend.assembleProgram();
@@ skipping 779 matching lines @@
     return futureClass.computeType(compiler).createInstantiation([elementType]);
   }
 
   @override
   InterfaceType streamType([DartType elementType = const DynamicType()]) {
     return streamClass.computeType(compiler).createInstantiation([elementType]);
   }
 }
 
 typedef void InternalErrorFunction(Spannable location, String message);