Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon.gypi

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Making FallbackIconSource take FallbackIconService directly. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/base/testing_profile.cc ('K') | « chrome/test/base/testing_profile.cc ('k') | components/favicon/core/BUILD.gn » ('j') | components/favicon_base/fallback_icon_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon.gypi
diff --git a/components/favicon.gypi b/components/favicon.gypi
index 262bd2b4fe60cbbba32eb76dd4f52a29b896acf6..eced7bf628ca13afc321d9170b17800cfa2dd56a 100644
--- a/components/favicon.gypi
+++ b/components/favicon.gypi
@@ -15,6 +15,7 @@
],
'sources': [
# Note: sources list duplicated in GN build.
+ 'favicon/core/browser/fallback_icon_client.h',
'favicon/core/browser/favicon_client.h',
'favicon/core/favicon_driver.h',
'favicon/core/favicon_url.cc',
« chrome/test/base/testing_profile.cc ('K') | « chrome/test/base/testing_profile.cc ('k') | components/favicon/core/BUILD.gn » ('j') | components/favicon_base/fallback_icon_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698