chrome/test/base/testing_profile.h - Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/testing_profile.h

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Making FallbackIconSource take FallbackIconService directly. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/favicon/fallback_icon_service_factory.cc ('K') | « chrome/chrome_browser.gypi ('k') | chrome/test/base/testing_profile.cc » ('j') | chrome/test/base/testing_profile.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/testing_profile.h

diff --git a/chrome/test/base/testing_profile.h b/chrome/test/base/testing_profile.h

index 8db54eea1cb6ddf1d9fd6b1ddd14430a5ceee98e..252fdfbc7bba868953bc090da0021e4ceb8b11de 100644

--- a/chrome/test/base/testing_profile.h

+++ b/chrome/test/base/testing_profile.h

@@ -164,6 +164,10 @@ class TestingProfile : public Profile {

~TestingProfile() override;

+ // Creates the fallback icon service. Consequent calls would recreate the

+ // service.

+ void CreateFallbackIconService();

// Creates the favicon service. Consequent calls would recreate the service.

void CreateFaviconService();

« chrome/browser/favicon/fallback_icon_service_factory.cc ('K') | « chrome/chrome_browser.gypi ('k') | chrome/test/base/testing_profile.cc » ('j') | chrome/test/base/testing_profile.cc » ('J')