components/favicon/core/BUILD.gn - Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/BUILD.gn

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync and reverting small unneeded change. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/base/testing_profile.h ('K') | « components/favicon.gypi ('k') | components/favicon/core/browser/fallback_icon_client.h » ('j') | components/favicon/core/browser/fallback_icon_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/favicon/core/BUILD.gn

diff --git a/components/favicon/core/BUILD.gn b/components/favicon/core/BUILD.gn

index 0f834cb1d8538adcac7c91f4c4ab32260d29539e..97ea4a44c4e83099972d8bd8a52f81487de87836 100644

--- a/components/favicon/core/BUILD.gn

+++ b/components/favicon/core/BUILD.gn

@@ -4,6 +4,7 @@

static_library("core") {

sources = [

+ "browser/fallback_icon_client.h",

"browser/favicon_client.h",

"favicon_driver.h",

"favicon_url.cc",