Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4087)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/ntp/most_visited_handler.cc

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync and reverting small unneeded change. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/webui/fallback_icon_source.cc ('K') | « chrome/browser/ui/webui/fallback_icon_source.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/test/base/testing_profile.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/most_visited_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/most_visited_handler.cc b/chrome/browser/ui/webui/ntp/most_visited_handler.cc
index 39a1f2fb5c85c239559cf13fcd4d04a4700fe738..2def30813c341a90745eec8c1b088f926e2719b0 100644
--- a/chrome/browser/ui/webui/ntp/most_visited_handler.cc
+++ b/chrome/browser/ui/webui/ntp/most_visited_handler.cc
@@ -20,6 +20,7 @@
#include "base/strings/utf_string_conversions.h"
#include "base/threading/thread.h"
#include "base/values.h"
+#include "chrome/browser/favicon/chrome_fallback_icon_client_factory.h"
#include "chrome/browser/history/top_sites_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/thumbnails/thumbnail_list_source.h"
@@ -81,7 +82,9 @@ void MostVisitedHandler::RegisterMessages() {
content::URLDataSource::Add(profile, new ThumbnailListSource(profile));
// Register chrome://fallback-icon as a data source for fallback icons.
- content::URLDataSource::Add(profile, new FallbackIconSource());
+ content::URLDataSource::Add(profile,
+ new FallbackIconSource(
+ ChromeFallbackIconClientFactory::GetForProfile(profile)));
sdefresne 2015/03/16 09:11:29 Same.
huangs 2015/03/16 22:06:11 Done.
// Register chrome://favicon as a data source for favicons.
content::URLDataSource::Add(
« chrome/browser/ui/webui/fallback_icon_source.cc ('K') | « chrome/browser/ui/webui/fallback_icon_source.cc ('k') | chrome/chrome_browser.gypi » ('j') | chrome/test/base/testing_profile.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698