chrome/chrome_browser.gypi - Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/ntp/most_visited_handler.cc ('k') | chrome/test/base/testing_profile.h » ('j') | components/favicon/core/browser/fallback_icon_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index c982e65060768bfea158b94a5cb410ea0d5135ab..fbc0af2689d7f2aaaf1f7e2f2322b9238dc00936 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1511,10 +1511,16 @@

'browser/sync_file_system/task_logger.h',

'chrome_browser_favicon_sources': [

+ 'browser/favicon/chrome_fallback_icon_client.cc',

+ 'browser/favicon/chrome_fallback_icon_client.h',

+ 'browser/favicon/chrome_fallback_icon_client_factory.cc',

+ 'browser/favicon/chrome_fallback_icon_client_factory.h',

'browser/favicon/chrome_favicon_client.cc',

'browser/favicon/chrome_favicon_client.h',

'browser/favicon/chrome_favicon_client_factory.cc',

'browser/favicon/chrome_favicon_client_factory.h',

+ 'browser/favicon/fallback_icon_service_factory.cc',

+ 'browser/favicon/fallback_icon_service_factory.h',

'browser/favicon/favicon_handler.cc',

'browser/favicon/favicon_handler.h',

'browser/favicon/favicon_service.cc',