[Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

chrome/browser/favicon/chrome_fallback_icon_client.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_FAVICON_CHROME_FALLBACK_ICON_CLIENT_H_
+#define CHROME_BROWSER_FAVICON_CHROME_FALLBACK_ICON_CLIENT_H_
+
+#include "components/favicon/core/browser/fallback_icon_client.h"
+
+#include <string>
+#include <vector>
+
+#include "base/macros.h"
+
+class GURL;
+class Profile;
+
+namespace favicon_base {
+class FallbackIconService;
+}  // namespace favicon_base
+
+// ChromeFallbackIconClient implements the the FallbackIconClient interface.

[sdefresne, 2015/03/17 09:41:52]

nit: s/the the/the/

[huangs, 2015/03/23 03:28:34]

Done.

+class ChromeFallbackIconClient : public FallbackIconClient {
+ public:
+  explicit ChromeFallbackIconClient(Profile* profile);

[sdefresne, 2015/03/17 09:41:52]

You don't use profile, so there is no need to pass it to the constructor nor
keep a pointer to it as a member variable.

[huangs, 2015/03/23 03:28:34]

Done.

+  ~ChromeFallbackIconClient() override;
+
+  // FallbackIconClient implementation:
+  const std::vector<std::string>& GetFontNameList() override;
+
+ private:
+  Profile* profile_;
+
+  std::vector<std::string> font_list_;
+
+  DISALLOW_COPY_AND_ASSIGN(ChromeFallbackIconClient);
+};
+
+#endif  // CHROME_BROWSER_FAVICON_CHROME_FALLBACK_ICON_CLIENT_H_