Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: components/favicon.gypi

Issue 996253002: [Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync and reverting small unneeded change. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/favicon/core 8 # GN version: //components/favicon/core
9 'target_name': 'favicon_core', 9 'target_name': 'favicon_core',
10 'type': 'static_library', 10 'type': 'static_library',
11 'dependencies': [ 11 'dependencies': [
12 '../ui/gfx/gfx.gyp:gfx_geometry', 12 '../ui/gfx/gfx.gyp:gfx_geometry',
13 'favicon_base', 13 'favicon_base',
14 'keyed_service_core', 14 'keyed_service_core',
15 ], 15 ],
16 'sources': [ 16 'sources': [
17 # Note: sources list duplicated in GN build. 17 # Note: sources list duplicated in GN build.
18 'favicon/core/browser/fallback_icon_client.h',
18 'favicon/core/browser/favicon_client.h', 19 'favicon/core/browser/favicon_client.h',
19 'favicon/core/favicon_driver.h', 20 'favicon/core/favicon_driver.h',
20 'favicon/core/favicon_url.cc', 21 'favicon/core/favicon_url.cc',
21 'favicon/core/favicon_url.h', 22 'favicon/core/favicon_url.h',
22 ], 23 ],
23 'include_dirs': [ 24 'include_dirs': [
24 '..', 25 '..',
25 ], 26 ],
26 }, 27 },
27 ], 28 ],
28 } 29 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698