[Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

chrome/browser/ui/webui/large_icon_source.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/large_icon_source.h"
 
-#include <string>
 #include <vector>
 
 #include "base/memory/ref_counted_memory.h"
-#include "chrome/browser/favicon/favicon_service_factory.h"
-#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/instant_io_context.h"
 #include "chrome/common/favicon/large_icon_url_parser.h"
 #include "chrome/common/url_constants.h"
+#include "components/favicon/core/fallback_icon_service.h"
 #include "components/favicon/core/favicon_service.h"
 #include "components/favicon_base/fallback_icon_style.h"
-#include "grit/platform_locale_settings.h"
 #include "net/url_request/url_request.h"
 #include "third_party/skia/include/core/SkColor.h"
-#include "ui/base/l10n/l10n_util.h"
 
 namespace {
 
 int kDefaultLargeIconSize = 96;
 int kMaxLargeIconSize = 192;  // Arbitrary bound to safeguard endpoint.
 
 }  // namespace
 
 LargeIconSource::IconRequest::IconRequest() : size(kDefaultLargeIconSize) {
 }
 
 LargeIconSource::IconRequest::IconRequest(
     const content::URLDataSource::GotDataCallback& callback_in,
     const GURL& url_in,
     int size_in)
     : callback(callback_in),
       url(url_in),
       size(size_in) {
 }
 
 LargeIconSource::IconRequest::~IconRequest() {
 }
 
-LargeIconSource::LargeIconSource(Profile* profile) : profile_(profile) {
-  std::vector<std::string> font_list;
-#if defined(OS_CHROMEOS)
-  font_list.push_back("Noto Sans");
-#elif defined(OS_IOS)
-  font_list.push_back("Helvetica Neue");
-#else
-  font_list.push_back(l10n_util::GetStringUTF8(IDS_SANS_SERIF_FONT_FAMILY));
-#endif
-  fallback_icon_service_.reset(new FallbackIconService(font_list));
+LargeIconSource::LargeIconSource(FaviconService* favicon_service,
+                                 FallbackIconService* fallback_icon_service)
+    : favicon_service_(favicon_service),
+      fallback_icon_service_(fallback_icon_service) {
 }
 
 LargeIconSource::~LargeIconSource() {
 }
 
 std::string LargeIconSource::GetSource() const {
   return chrome::kChromeUILargeIconHost;
 }
 
 void LargeIconSource::StartDataRequest(
     const std::string& path,
     int render_process_id,
     int render_frame_id,
     const content::URLDataSource::GotDataCallback& callback) {
+  if (!favicon_service_) {
+    SendNotFoundResponse(callback);
+    return;
+  }
+
   LargeIconUrlParser parser;
   bool success = parser.Parse(path);
-  if (!success || parser.size_in_pixels() <= 0 ||
+  if (!success ||
+      parser.size_in_pixels() <= 0 ||
       parser.size_in_pixels() > kMaxLargeIconSize) {
     SendNotFoundResponse(callback);
     return;
   }
-
-  FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(
-      profile_, ServiceAccessType::EXPLICIT_ACCESS);
-  if (!favicon_service) {
-    SendNotFoundResponse(callback);
-    return;
-  }
 
   GURL url(parser.url_string());
   if (!url.is_valid()) {
     SendNotFoundResponse(callback);
     return;
   }
 
-  favicon_service->GetRawFaviconForPageURL(
+  favicon_service_->GetRawFaviconForPageURL(
       url,
       favicon_base::TOUCH_ICON | favicon_base::TOUCH_PRECOMPOSED_ICON,
       parser.size_in_pixels(),
       base::Bind(
           &LargeIconSource::OnIconDataAvailable,
           base::Unretained(this),
           IconRequest(callback, url, parser.size_in_pixels())),
       &cancelable_task_tracker_);
 }
 
@@ skipping 19 matching lines @@
 void LargeIconSource::OnIconDataAvailable(
     const IconRequest& request,
     const favicon_base::FaviconRawBitmapResult& bitmap_result) {
   if (!bitmap_result.is_valid())
     SendFallbackIcon(request);
   else
     request.callback.Run(bitmap_result.bitmap_data.get());
 }
 
 void LargeIconSource::SendFallbackIcon(const IconRequest& request) {
+  if (!fallback_icon_service_) {
+    SendNotFoundResponse(request.callback);
+    return;
+  }
   favicon_base::FallbackIconStyle style;
   style.background_color = SkColorSetRGB(0xcc, 0xcc, 0xcc);
   favicon_base::MatchFallbackIconTextColorAgainstBackgroundColor(&style);
   style.roundness = 1.0;
   std::vector<unsigned char> bitmap_data =
       fallback_icon_service_->RenderFallbackIconBitmap(
           request.url, request.size, style);
   request.callback.Run(base::RefCountedBytes::TakeVector(&bitmap_data));
 }
 
 void LargeIconSource::SendNotFoundResponse(
     const content::URLDataSource::GotDataCallback& callback) {
   callback.Run(nullptr);
 }