[Fallback Icons] Refactor FallbackIconService to be a BrowserContext-level singleton

components/favicon/core/browser/fallback_icon_client.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_FAVICON_CORE_BROWSER_FALLBACK_ICON_CLIENT_H_
+#define COMPONENTS_FAVICON_CORE_BROWSER_FALLBACK_ICON_CLIENT_H_
+
+#include <string>
+#include <vector>
+
+#include "components/keyed_service/core/keyed_service.h"
+
+namespace favicon_base {
+class FallbackIconService;
+}  // namespace favicon_base
+
+// This class abstracts operations that depend on the embedder's environment,
+// e.g. Chrome.
+class FallbackIconClient : public KeyedService {
+ public:
+  ~FallbackIconClient() override{};

[sdefresne, 2015/03/11 16:22:05]

nit: remove trailing semi-colon, style is

~FallbackIconClient() override {}

[huangs, 2015/03/11 18:00:25]

Done.  This was copied from favicon_client.h though.  Updating that as well.

[sdefresne, 2015/03/11 18:06:20]

FaviconClient is already fixed by https://codereview.chromium.org/987113005/.

+
+  virtual favicon_base::FallbackIconService* GetFallbackIconService() = 0;

[sdefresne, 2015/03/11 16:22:05]

drive-by: please put comment for those methods

[huangs, 2015/03/11 18:00:25]

Done, also renamed GetFontList() to GetFontNameList() since gfx:FontList() is
something else.

+
+  virtual const std::vector<std::string>& GetFontList() = 0;
+};
+
+#endif  // COMPONENTS_FAVICON_CORE_BROWSER_FALLBACK_ICON_CLIENT_H_