Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 99623003: Initialize ICU early in npchrome_frame.dll's lifetime. (Closed)

Created:
7 years ago by grt (UTC plus 2)
Modified:
7 years ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, amit, robertshield
Visibility:
Public.

Description

Initialize ICU early in npchrome_frame.dll's lifetime. This fixes a crash when navigating to an URL containing an internationalized domain name. BUG=324855 R=robertshield@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238226

Patch Set 1 #

Patch Set 2 : ignore initialization failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome_frame/chrome_tab.cc View 1 4 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
7 years ago (2013-12-02 18:22:02 UTC) #1
robertshield
lgtm
7 years ago (2013-12-02 18:37:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/99623003/20001
7 years ago (2013-12-02 21:09:52 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 23:24:22 UTC) #4
Message was sent while issue was closed.
Change committed as 238226

Powered by Google App Engine
This is Rietveld 408576698