Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 996223002: Resolve cctest/test-deoptimization/DeoptimizeCompare failure on PPC (Closed)

Created:
5 years, 9 months ago by michael_dawson
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

cctest/test-deoptimization/DeoptimizeCompare was failing on PPC because the path that is optimized for isel incorrectly used integer values instead of Smi's BUG= Committed: https://crrev.com/d88656af9f34cb2783c6c0217f27e5789d3d2591 Cr-Commit-Position: refs/heads/master@{#27136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
michael_dawson
Next incremental change required for PPC
5 years, 9 months ago (2015-03-11 14:16:58 UTC) #2
Sven Panne
lgtm
5 years, 9 months ago (2015-03-11 14:30:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996223002/1
5 years, 9 months ago (2015-03-11 14:30:27 UTC) #5
Sven Panne
Just FYI: We re-arranged our waterfall (http://build.chromium.org/p/client.v8/console) a bit, so one can now clearly see ...
5 years, 9 months ago (2015-03-11 14:35:47 UTC) #6
michael_dawson
On 2015/03/11 14:35:47, Sven Panne wrote: > Just FYI: We re-arranged our waterfall > (http://build.chromium.org/p/client.v8/console) ...
5 years, 9 months ago (2015-03-11 14:43:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 14:58:01 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 14:58:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d88656af9f34cb2783c6c0217f27e5789d3d2591
Cr-Commit-Position: refs/heads/master@{#27136}

Powered by Google App Engine
This is Rietveld 408576698