Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 996213003: Hide native Date implementation in function context. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Hide native Date implementation in function context. This further reduces the context size. R=jkummerow@chromium.org Committed: https://crrev.com/9333e7e1359e2676307ae148c3fbde81b26b18e1 Cr-Commit-Position: refs/heads/master@{#27138}

Patch Set 1 #

Patch Set 2 : padded formatting #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -161 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/date.js View 4 chunks +79 lines, -75 lines 0 comments Download
M src/i18n.js View 14 chunks +33 lines, -70 lines 1 comment Download
M src/math.js View 5 chunks +12 lines, -12 lines 0 comments Download
M src/snapshot-common.cc View 1 2 chunks +25 lines, -0 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 2 chunks +7 lines, -3 lines 0 comments Download
M src/v8natives.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Yang
5 years, 9 months ago (2015-03-11 15:13:22 UTC) #1
Yang
Log output when running mksnapshot with --profile-deserialization Deserialization will reserve: 806680 bytes for startup 323736 ...
5 years, 9 months ago (2015-03-11 15:16:09 UTC) #2
Jakob Kummerow
LGTM with a comment. https://codereview.chromium.org/996213003/diff/20001/src/i18n.js File src/i18n.js (right): https://codereview.chromium.org/996213003/diff/20001/src/i18n.js#newcode19 src/i18n.js:19: var undefined = global.undefined; How ...
5 years, 9 months ago (2015-03-11 15:46:55 UTC) #3
Yang
On 2015/03/11 15:46:55, Jakob wrote: > LGTM with a comment. > > https://codereview.chromium.org/996213003/diff/20001/src/i18n.js > File ...
5 years, 9 months ago (2015-03-11 15:51:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996213003/20001
5 years, 9 months ago (2015-03-11 15:52:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-11 15:53:29 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 15:53:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9333e7e1359e2676307ae148c3fbde81b26b18e1
Cr-Commit-Position: refs/heads/master@{#27138}

Powered by Google App Engine
This is Rietveld 408576698