Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(633)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: resources/invalid_images/ico_fuzz0.ico
Issue
996173005
:
Ico security issues fix (Closed)
Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: actually fixed it this time
Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
resources/invalid_images/ico_fuzz0.ico
resources/invalid_images/ico_fuzz1.ico
resources/invalid_images/ico_leak01.ico
src/images/SkImageDecoder_libico.cpp
tests/BadIcoTest.cpp
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« no previous file
|
resources/invalid_images/ico_fuzz1.ico »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
« no previous file with comments
|
« no previous file
|
resources/invalid_images/ico_fuzz1.ico »
('j') |
no next file with comments »
Issue 996173005: Ico security issues fix (Closed)
Created 5 years, 9 months ago by msarett
Modified 5 years, 9 months ago
Reviewers: scroggo, hcm
Base URL: https://skia.googlesource.com/skia.git@master
Comments: 21
This is Rietveld
408576698
Chromium Code Reviews
Issue 996173005:
Ico security issues fix (Closed)
Base URL: https://skia.googlesource.com/skia.git@master
