Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 996163005: [Cronet] Delay StartNetLog and StopNetLog until native request context is initialized (Closed)

Created:
5 years, 9 months ago by xunjieli
Modified:
5 years, 9 months ago
Reviewers:
pauljensen
CC:
chromium-reviews, cbentzel+watch_chromium.org, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Delay StartNetLog and StopNetLog until native request context is initialized Use CronetURLRequestAdapter::PostTaskToNetworkThread instead of posting the task directly to network thread to make sure the start/stop netlog task is executed after request context is fully initialized. Also changed the test cases to make sure that we don't regress. BUG=470196 Committed: https://crrev.com/bb7cf7be5f6204564859331576e0e8b0364e038a Cr-Commit-Position: refs/heads/master@{#322577}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added DCHECKs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M components/cronet/android/cronet_url_request_context_adapter.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 2 chunks +14 lines, -7 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java View 2 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xunjieli
5 years, 9 months ago (2015-03-26 17:21:08 UTC) #2
pauljensen
lgtm. Do the two tests pass without the cronet_url_request_context_adapter.cc fix? https://codereview.chromium.org/996163005/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc File components/cronet/android/cronet_url_request_context_adapter.cc (right): https://codereview.chromium.org/996163005/diff/1/components/cronet/android/cronet_url_request_context_adapter.cc#newcode286 ...
5 years, 9 months ago (2015-03-27 13:11:13 UTC) #3
xunjieli
Without the fix, CronetUrlRequestContextTest#testNetLog will fail. However, CronetUrlTest#testNetLog tests the old API (which does not ...
5 years, 9 months ago (2015-03-27 13:34:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996163005/20001
5 years, 9 months ago (2015-03-27 14:35:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-27 14:58:23 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 14:59:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb7cf7be5f6204564859331576e0e8b0364e038a
Cr-Commit-Position: refs/heads/master@{#322577}

Powered by Google App Engine
This is Rietveld 408576698