Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 996163003: Offscreen framebuffer creation on Mali-400 GPU (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/config/gpu_driver_bug_list_json.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 0886768193444d6e61c7467c5ef30e28aeaf85a6..7e51c4dc10053e0ec1dc03c31ca6bb319a8ff2be 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -2613,8 +2613,8 @@ bool GLES2DecoderImpl::Initialize(
GL_RGBA8 : GL_RGB8;
} else {
offscreen_target_samples_ = 1;
- offscreen_target_color_format_ = attrib_parser.alpha_size > 0 ?
- GL_RGBA : GL_RGB;
+ offscreen_target_color_format_ = attrib_parser.alpha_size > 0 ||
+ workarounds().disable_gl_rgb_format ? GL_RGBA : GL_RGB;
piman 2015/03/31 04:06:30 nit: can you fix indenting? e.g. by running git cl
}
// ANGLE only supports packed depth/stencil formats, so use it if it is
@@ -2636,8 +2636,8 @@ bool GLES2DecoderImpl::Initialize(
GL_STENCIL_INDEX8 : 0;
}
} else {
- offscreen_target_color_format_ = attrib_parser.alpha_size > 0 ?
- GL_RGBA : GL_RGB;
+ offscreen_target_color_format_ = attrib_parser.alpha_size > 0 ||
+ workarounds().disable_gl_rgb_format ? GL_RGBA : GL_RGB;
// If depth is requested at all, use the packed depth stencil format if
// it's available, as some desktop GL drivers don't support any non-packed
@@ -2659,8 +2659,8 @@ bool GLES2DecoderImpl::Initialize(
}
}
- offscreen_saved_color_format_ = attrib_parser.alpha_size > 0 ?
- GL_RGBA : GL_RGB;
+ offscreen_saved_color_format_ = attrib_parser.alpha_size > 0 ||
+ workarounds().disable_gl_rgb_format ? GL_RGBA : GL_RGB;
// Create the target frame buffer. This is the one that the client renders
// directly to.
« no previous file with comments | « no previous file | gpu/config/gpu_driver_bug_list_json.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698