Offscreen framebuffer creation on Mali-400 GPU

Offscreen framebuffer creation on Mali-400 GPU

Make GPU bug workaround to disable using GL_RGB format on Mali-400

This CL manages offscreen framebuffer creation based on GL_RGBA format
and ignoring GL_RGB format because it is not supported on Mali-400 GPU.

BUG=449150
Committed: https://crrev.com/0aaf8db1aff9bc9b0c73bab6c603d21f95288ef3
Cr-Commit-Position: refs/heads/master@{#327487}

[rahulg, 2015-03-26 13:36:59]

rahul.g@samsung.com changed reviewers:
+ kbr@chromium.org

[rahulg, 2015-03-26 13:40:04]

rahul.g@samsung.com changed reviewers:
+ piman@chromium.org, sievers@chromium.org

[rahulg, 2015-03-27 05:04:48]

PTAL

[Ken Russell (switch to Gerrit), 2015-03-31 02:53:33]

kbr@chromium.org changed reviewers:
+ vmiura@chromium.org

[Ken Russell (switch to Gerrit), 2015-03-31 02:53:34]

LGTM, but you'll need an OWNERS review in gpu/command_buffer/service.

[piman, 2015-03-31 04:06:30]

lgtm

https://codereview.chromium.org/996163003/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/996163003/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2617:
workarounds().disable_gl_rgb_format ? GL_RGBA : GL_RGB;
nit: can you fix indenting? e.g. by running git cl format. The line continuation
should be at +4, like it was before.

(same several places below)

[rahulg, 2015-04-01 14:51:40]

On 2015/03/31 04:06:30, piman (Very slow to review) wrote:
> lgtm
> 
>
https://codereview.chromium.org/996163003/diff/1/gpu/command_buffer/service/g...
> File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):
> 
>
https://codereview.chromium.org/996163003/diff/1/gpu/command_buffer/service/g...
> gpu/command_buffer/service/gles2_cmd_decoder.cc:2617:
> workarounds().disable_gl_rgb_format ? GL_RGBA : GL_RGB;
> nit: can you fix indenting? e.g. by running git cl format. The line
continuation
> should be at +4, like it was before.
> 
> (same several places below)

@piman : Thanks for pointing it, I fixed indentation by running  git cl format,
please review.

[piman, 2015-04-01 19:38:44]

lgtm

[rahulg, 2015-04-03 07:52:24]

The CQ bit was checked by rahul.g@samsung.com

[rahulg, 2015-04-03 07:52:24]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/996163003/#ps80001 (title:
"fixed indenting")

[commit-bot: I haz the power, 2015-04-03 07:52:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996163003/80001

[rahulg, 2015-04-03 07:53:21]

The CQ bit was unchecked by rahul.g@samsung.com

[rahulg, 2015-04-03 07:53:22]

The CQ bit was checked by rahul.g@samsung.com

[commit-bot: I haz the power, 2015-04-03 07:55:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996163003/80001

[commit-bot: I haz the power, 2015-04-03 08:02:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 08:02:17]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rahulg, 2015-04-03 09:04:34]

The CQ bit was checked by rahul.g@samsung.com

[rahulg, 2015-04-03 09:04:34]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/996163003/#ps100001
(title: "JSON version number updated")

[commit-bot: I haz the power, 2015-04-03 09:04:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996163003/100001

[commit-bot: I haz the power, 2015-04-03 09:14:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 09:14:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rahulg, 2015-04-03 11:07:21]

The CQ bit was checked by rahul.g@samsung.com

[rahulg, 2015-04-03 11:07:21]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/996163003/#ps120001
(title: " ")

[commit-bot: I haz the power, 2015-04-03 11:07:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996163003/120001

[commit-bot: I haz the power, 2015-04-03 11:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 11:15:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ken Russell (switch to Gerrit), 2015-04-03 21:02:20]

On 2015/04/03 11:15:52, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

The presubmit check is failing because you aren't listed in the AUTHORS file.

[halliwell, 2015-04-28 22:33:54]

On 2015/04/03 21:02:20, Ken Russell wrote:
> On 2015/04/03 11:15:52, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> The presubmit check is failing because you aren't listed in the AUTHORS file.

Hi - I just stumbled across the bug for this CL, it's something I need a fix
for.

What's the status of this CL (looks ready to go but hasn't been updated in a
while?)

Can I help out, either pushing this forward or with the Blink side changes?

[piman, 2015-04-28 23:34:16]

On 2015/04/28 22:33:54, halliwell wrote:
> On 2015/04/03 21:02:20, Ken Russell wrote:
> > On 2015/04/03 11:15:52, I haz the power (commit-bot) wrote:
> > > Try jobs failed on following builders:
> > >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > 
> > The presubmit check is failing because you aren't listed in the AUTHORS
file.
> 
> Hi - I just stumbled across the bug for this CL, it's something I need a fix
> for.
> 
> What's the status of this CL (looks ready to go but hasn't been updated in a
> while?)
> 
> Can I help out, either pushing this forward or with the Blink side changes?

rahul.g@samsung.com is in the CLA signers list, so it's really just about fixing
the AUTHORS file.

[rahulg, 2015-04-29 01:44:26]

On 2015/04/28 23:34:16, piman (Very slow to review) wrote:
> On 2015/04/28 22:33:54, halliwell wrote:
> > On 2015/04/03 21:02:20, Ken Russell wrote:
> > > On 2015/04/03 11:15:52, I haz the power (commit-bot) wrote:
> > > > Try jobs failed on following builders:
> > > >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> > > >
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > > 
> > > The presubmit check is failing because you aren't listed in the AUTHORS
> file.
> > 
> > Hi - I just stumbled across the bug for this CL, it's something I need a fix
> > for.
> > 
> > What's the status of this CL (looks ready to go but hasn't been updated in a
> > while?)
> > 
> > Can I help out, either pushing this forward or with the Blink side changes?
> 
> mailto:rahul.g@samsung.com is in the CLA signers list, so it's really just
about fixing
> the AUTHORS file.

I have requested long back to add my name in author list.
https://codereview.chromium.org/1058303004/ but seems it is pending or I
requested wrongly.
I would like to request you if you can help out to add my name in author list.

[piman, 2015-04-29 02:09:33]

On Tue, Apr 28, 2015 at 6:44 PM, <rahul.g@samsung.com> wrote:

> On 2015/04/28 23:34:16, piman (Very slow to review) wrote:
>
>> On 2015/04/28 22:33:54, halliwell wrote:
>> > On 2015/04/03 21:02:20, Ken Russell wrote:
>> > > On 2015/04/03 11:15:52, I haz the power (commit-bot) wrote:
>> > > > Try jobs failed on following builders:
>> > > >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>> > > >
>> > >
>> >
>>
>
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...
> )
>
>> > >
>> > > The presubmit check is failing because you aren't listed in the
>> AUTHORS
>> file.
>> >
>> > Hi - I just stumbled across the bug for this CL, it's something I need
>> a fix
>> > for.
>> >
>> > What's the status of this CL (looks ready to go but hasn't been updated
>> in a
>> > while?)
>> >
>> > Can I help out, either pushing this forward or with the Blink side
>> changes?
>>
>
>  mailto:rahul.g@samsung.com is in the CLA signers list, so it's really
>> just
>>
> about fixing
>
>> the AUTHORS file.
>>
>
> I have requested long back to add my name in author list.
> https://codereview.chromium.org/1058303004/ but seems it is pending or I
> requested wrongly.
> I would like to request you if you can help out to add my name in author
> list.
>

Usually that is done with the same CL as your first contribution.
I LGTM'd that change.

>
> https://codereview.chromium.org/996163003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rahulg, 2015-04-29 02:13:00]

> Usually that is done with the same CL as your first contribution.
> I LGTM'd that change.

Thank you.

[rahulg, 2015-04-29 12:36:35]

The CQ bit was checked by rahul.g@samsung.com

[rahulg, 2015-04-29 12:36:35]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/996163003/#ps180001
(title: "JSON version updated")

[commit-bot: I haz the power, 2015-04-29 12:36:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996163003/180001

[commit-bot: I haz the power, 2015-04-29 14:18:16]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-04-29 14:19:24]

Patchset 10 (id:??) landed as
https://crrev.com/0aaf8db1aff9bc9b0c73bab6c603d21f95288ef3
Cr-Commit-Position: refs/heads/master@{#327487}