Source/web/WebViewImpl.cpp - Issue 996163002: Add an explicit dispose step for WebDevToolsAgentImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 996163002: Add an explicit dispose step for WebDevToolsAgentImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index 52ceb368bd48402cb0bdc40e5228260df2e522cd..00da05fa738dcf33756e7a6223b174e2a3886cd3 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -1676,8 +1676,10 @@ void WebViewImpl::close()

}

// Should happen after m_page.clear().

- if (m_devToolsAgent)

+ if (m_devToolsAgent) {

+ m_devToolsAgent->dispose();

m_devToolsAgent.clear();

+ }

// Reset the delegate to prevent notifications being sent as we're being

// deleted.

« no previous file with comments | « Source/web/WebDevToolsAgentImpl.cpp ('k') | no next file » | no next file with comments »