Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Unified Diff: Source/web/WebDevToolsAgentImpl.h

Issue 996163002: Add an explicit dispose step for WebDevToolsAgentImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDevToolsAgentImpl.h
diff --git a/Source/web/WebDevToolsAgentImpl.h b/Source/web/WebDevToolsAgentImpl.h
index b96bb066bca8bfeecf99d8ab33aefcf8f2f7065c..a54c0bc098f5699742354b963cd96f48b38163c3 100644
--- a/Source/web/WebDevToolsAgentImpl.h
+++ b/Source/web/WebDevToolsAgentImpl.h
@@ -75,6 +75,7 @@ class WebDevToolsAgentImpl final
public:
WebDevToolsAgentImpl(WebViewImpl*, WebDevToolsAgentClient*);
~WebDevToolsAgentImpl() override;
+ void dispose();
DECLARE_VIRTUAL_TRACE();
void willBeDestroyed();
@@ -164,6 +165,9 @@ private:
WebDevToolsAgentClient* m_client;
WebViewImpl* m_webViewImpl;
bool m_attached;
+#if ENABLE(ASSERT)
+ bool m_hasBeenDisposed;
+#endif
RefPtrWillBeMember<InstrumentingAgents> m_instrumentingAgents;
OwnPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
« no previous file with comments | « no previous file | Source/web/WebDevToolsAgentImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698