Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 996163002: Add an explicit dispose step for WebDevToolsAgentImpl. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add an explicit dispose step for WebDevToolsAgentImpl. In order to provide an orderly shutdown of a WebViewImpl's WebDevToolsAgentImpl object, add a dispose() step before clearing out its reference. Delaying the dispose steps until WebDevToolsAgentImpl is finalized, is incompatible with Oilpan. R=haraken BUG=451004 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M Source/web/WebDevToolsAgentImpl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
please take a look.
5 years, 9 months ago (2015-03-11 10:42:17 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-11 11:00:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996163002/1
5 years, 9 months ago (2015-03-11 11:05:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=191698
5 years, 9 months ago (2015-03-11 12:51:44 UTC) #6
dgozman
On 2015/03/11 12:51:44, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
5 years, 9 months ago (2015-03-11 15:20:44 UTC) #7
sof
5 years, 9 months ago (2015-03-11 15:32:04 UTC) #8
Message was sent while issue was closed.
On 2015/03/11 15:20:44, dgozman wrote:
> On 2015/03/11 12:51:44, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1) as
> > https://src.chromium.org/viewvc/blink?view=rev&revision=191698
> 
> There is already |willBeDestroyed| method on the same class. Does it suit for
> your needs?

Don't/didn't think so; that's issued first thing when closing the view; the
dispose happens after the page has been destroyed.

Powered by Google App Engine
This is Rietveld 408576698