CpuProfiler: simplify inlined function info magic.

CpuProfiler: simplify inlined function info magic.

I did some investigation and found that in the most cases
the old schema with the separate List for functions and inlines
gives us no memory benefits because more frequently we inlines
different functions into parent function. So the plain schema
wins a tens or even hundreds bytes a few thousand times.

The only drawback is that we will print the inlined body
the each time when we inline it. But is not a problem
because it happens only under FLAG_hydrogen_track_positions.

Also I added script_id to the structure, so it could be used later
by cpu-profiler.

BUG=chromium:452067
LOG=n

Committed: https://crrev.com/df9e6fe329b5655932124a9d871d4eacbf51ce08
Cr-Commit-Position: refs/heads/master@{#27134}

[loislo, 2015-03-11 12:42:02]

loislo@chromium.org changed reviewers:
+ alph@chromium.org, svenpanne@chromium.org, yurys@chromium.org

[loislo, 2015-03-11 12:42:04]

PTAL

[yurys, 2015-03-11 13:05:21]

lgtm as long as I understand this code:)

https://codereview.chromium.org/996153003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/996153003/diff/1/src/compiler.cc#newcode278
src/compiler.cc:278: int pareint_id) {
typo: parent_id

https://codereview.chromium.org/996153003/diff/1/src/compiler.cc#newcode283
src/compiler.cc:283: InlinedFunctionInfo info(pareint_id, position, 0,
shared->start_position());
0 -> kNoScriptId ?

https://codereview.chromium.org/996153003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/996153003/diff/1/src/hydrogen.cc#newcode3456
src/hydrogen.cc:3456: -1);
kNoPosition

https://codereview.chromium.org/996153003/diff/1/src/hydrogen.cc#newcode3490
src/hydrogen.cc:3490: return info()
Weird formatting.

[loislo, 2015-03-11 13:15:47]

https://codereview.chromium.org/996153003/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/996153003/diff/1/src/compiler.cc#newcode278
src/compiler.cc:278: int pareint_id) {
On 2015/03/11 13:05:21, yurys wrote:
> typo: parent_id

Done.

https://codereview.chromium.org/996153003/diff/1/src/compiler.cc#newcode283
src/compiler.cc:283: InlinedFunctionInfo info(pareint_id, position, 0,
shared->start_position());
On 2015/03/11 13:05:21, yurys wrote:
> 0 -> kNoScriptId ?

Done.

https://codereview.chromium.org/996153003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/996153003/diff/1/src/hydrogen.cc#newcode3456
src/hydrogen.cc:3456: -1);
On 2015/03/11 13:05:21, yurys wrote:
> kNoPosition

done

https://codereview.chromium.org/996153003/diff/1/src/hydrogen.cc#newcode3490
src/hydrogen.cc:3490: return info()
On 2015/03/11 13:05:21, yurys wrote:
> Weird formatting.

Done.

[Sven Panne, 2015-03-11 13:42:19]

The CQ bit was checked by svenpanne@chromium.org

[Sven Panne, 2015-03-11 13:42:20]

lgtm

[Sven Panne, 2015-03-11 13:42:20]

The patchset sent to the CQ was uploaded after l-g-t-m from yurys@chromium.org
Link to the patchset: https://codereview.chromium.org/996153003/#ps20001 (title:
"comments addressed")

[commit-bot: I haz the power, 2015-03-11 13:42:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996153003/20001

[commit-bot: I haz the power, 2015-03-11 13:51:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-11 13:51:33]

Patchset 2 (id:??) landed as
https://crrev.com/df9e6fe329b5655932124a9d871d4eacbf51ce08
Cr-Commit-Position: refs/heads/master@{#27134}