src/runtime/runtime-array.cc - Issue 996153002: Bailout for %_FastOneByteArrayJoin again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-array.cc

Issue 996153002: Bailout for %_FastOneByteArrayJoin again. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: reformat Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime/runtime-array.cc

diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc

index 90a1e2c1ef3266405709491b9d61dec0bb808242..87d4f263ef42b135ee66a9914d8be384d4c389af 100644

--- a/src/runtime/runtime-array.cc

+++ b/src/runtime/runtime-array.cc

@@ -1338,15 +1338,18 @@ RUNTIME_FUNCTION(Runtime_HasCachedArrayIndex) {

RUNTIME_FUNCTION(Runtime_GetCachedArrayIndex) {

- SealHandleScope shs(isolate);

- DCHECK(args.length() == 1);

- return isolate->heap()->undefined_value();

+ // This can never be reached, because Runtime_GetCachedArrayIndex always

Michael Starzinger 2015/03/11 11:29:55 nit: s/Runtime_GetCachedArrayIndex/Runtime_HasCach

Sven Panne 2015/03/11 12:40:00 Done.

+ // returns false.

+ UNIMPLEMENTED();

+ return nullptr;

}

RUNTIME_FUNCTION(Runtime_FastOneByteArrayJoin) {

SealHandleScope shs(isolate);

DCHECK(args.length() == 2);

+ // Returning undefined means that this fast path fails and one has to resort

+ // to a slow path.

return isolate->heap()->undefined_value();

}

« no previous file with comments | « src/hydrogen.cc ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »