Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: src/runtime/runtime-array.cc

Issue 996153002: Bailout for %_FastOneByteArrayJoin again. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fixed comment. Rebased. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/runtime/runtime-utils.h" 8 #include "src/runtime/runtime-utils.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 1320 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 1331
1332 1332
1333 RUNTIME_FUNCTION(Runtime_HasCachedArrayIndex) { 1333 RUNTIME_FUNCTION(Runtime_HasCachedArrayIndex) {
1334 SealHandleScope shs(isolate); 1334 SealHandleScope shs(isolate);
1335 DCHECK(args.length() == 1); 1335 DCHECK(args.length() == 1);
1336 return isolate->heap()->false_value(); 1336 return isolate->heap()->false_value();
1337 } 1337 }
1338 1338
1339 1339
1340 RUNTIME_FUNCTION(Runtime_GetCachedArrayIndex) { 1340 RUNTIME_FUNCTION(Runtime_GetCachedArrayIndex) {
1341 SealHandleScope shs(isolate); 1341 // This can never be reached, because Runtime_HasCachedArrayIndex always
1342 DCHECK(args.length() == 1); 1342 // returns false.
1343 return isolate->heap()->undefined_value(); 1343 UNIMPLEMENTED();
1344 return nullptr;
1344 } 1345 }
1345 1346
1346 1347
1347 RUNTIME_FUNCTION(Runtime_FastOneByteArrayJoin) { 1348 RUNTIME_FUNCTION(Runtime_FastOneByteArrayJoin) {
1348 SealHandleScope shs(isolate); 1349 SealHandleScope shs(isolate);
1349 DCHECK(args.length() == 2); 1350 DCHECK(args.length() == 2);
1351 // Returning undefined means that this fast path fails and one has to resort
1352 // to a slow path.
1350 return isolate->heap()->undefined_value(); 1353 return isolate->heap()->undefined_value();
1351 } 1354 }
1352 } 1355 }
1353 } // namespace v8::internal 1356 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/runtime/runtime-classes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698