Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 996153002: Bailout for %_FastOneByteArrayJoin again. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bailout for %_FastOneByteArrayJoin again. This recovers the performance loss for some ancient benchmarks. Added some comments/UNIMPLEMENTED on the way. BUG=v8:3947 LOG=n Committed: https://crrev.com/88a7f24f46c2d0c9d7b19d80d73633ad901fd3c6 Cr-Commit-Position: refs/heads/master@{#27131}

Patch Set 1 #

Patch Set 2 : reformat #

Total comments: 2

Patch Set 3 : Fixed comment. Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M src/bailout-reason.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Sven Panne
5 years, 9 months ago (2015-03-11 10:20:53 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/996153002/diff/20001/src/runtime/runtime-array.cc File src/runtime/runtime-array.cc (right): https://codereview.chromium.org/996153002/diff/20001/src/runtime/runtime-array.cc#newcode1341 src/runtime/runtime-array.cc:1341: // This can never be reached, because Runtime_GetCachedArrayIndex ...
5 years, 9 months ago (2015-03-11 11:29:56 UTC) #3
Sven Panne
https://codereview.chromium.org/996153002/diff/20001/src/runtime/runtime-array.cc File src/runtime/runtime-array.cc (right): https://codereview.chromium.org/996153002/diff/20001/src/runtime/runtime-array.cc#newcode1341 src/runtime/runtime-array.cc:1341: // This can never be reached, because Runtime_GetCachedArrayIndex always ...
5 years, 9 months ago (2015-03-11 12:40:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996153002/40001
5 years, 9 months ago (2015-03-11 12:41:40 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-11 13:28:35 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 13:29:02 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/88a7f24f46c2d0c9d7b19d80d73633ad901fd3c6
Cr-Commit-Position: refs/heads/master@{#27131}

Powered by Google App Engine
This is Rietveld 408576698