Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 996143002: Do really include the beacon Blob content type if valid. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
haraken, Mike West
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do really include the beacon Blob content type if valid. The setting of a Blob beacon's content type was plain wrong and uninteresting. R=haraken BUG=466038 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191700

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/http/tests/navigation/beacon-same-origin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/beacon-same-origin-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/BeaconLoader.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look ..and save me blushing for too long?
5 years, 9 months ago (2015-03-11 10:28:02 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-11 10:57:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996143002/1
5 years, 9 months ago (2015-03-11 11:03:56 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 12:55:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191700

Powered by Google App Engine
This is Rietveld 408576698