correctly invalidate global cells

src/transitions.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/objects.h"
 #include "src/transitions-inl.h"
 #include "src/utils.h"
 
@@ skipping 19 matching lines @@
     ReplaceTransitions(map, *result);
   }
 
   bool is_special_transition = flag == SPECIAL_TRANSITION;
   // If the map has a simple transition, check if it should be overwritten.
   if (IsSimpleTransition(map->raw_transitions())) {
     Map* old_target = GetSimpleTransition(map->raw_transitions());
     Name* key = GetSimpleTransitionKey(old_target);
     PropertyDetails old_details = GetSimpleTargetDetails(old_target);
     PropertyDetails new_details = is_special_transition
-                                      ? PropertyDetails(NONE, DATA, 0)
+                                      ? PropertyDetails::Empty()
                                       : GetTargetDetails(*name, *target);
     if (flag == SIMPLE_PROPERTY_TRANSITION && key->Equals(*name) &&
         old_details.kind() == new_details.kind() &&
         old_details.attributes() == new_details.attributes()) {
       Handle<WeakCell> cell = Map::WeakCellForMap(target);
       ReplaceTransitions(map, *cell);
       return;
     }
     // Otherwise allocate a full TransitionArray with slack for a new entry.
     Handle<TransitionArray> result = Allocate(isolate, 1, 1);
     // Re-read existing data; the allocation might have caused it to be cleared.
     if (IsSimpleTransition(map->raw_transitions())) {
       old_target = GetSimpleTransition(map->raw_transitions());
       result->NoIncrementalWriteBarrierSet(
           0, GetSimpleTransitionKey(old_target), old_target);
     } else {
       result->SetNumberOfTransitions(0);
     }
     ReplaceTransitions(map, *result);
   }
 
   // At this point, we know that the map has a full TransitionArray.
   DCHECK(IsFullTransitionArray(map->raw_transitions()));
 
   int number_of_transitions = 0;
   int new_nof = 0;
   int insertion_index = kNotFound;
   DCHECK_EQ(is_special_transition, IsSpecialTransition(*name));
   PropertyDetails details = is_special_transition
-                                ? PropertyDetails(NONE, DATA, 0)
+                                ? PropertyDetails::Empty()
                                 : GetTargetDetails(*name, *target);
 
   {
     DisallowHeapAllocation no_gc;
     TransitionArray* array = TransitionArray::cast(map->raw_transitions());
     number_of_transitions = array->number_of_transitions();
     new_nof = number_of_transitions;
 
     int index =
         is_special_transition
@@ skipping 424 matching lines @@
 int TransitionArray::Search(PropertyKind kind, Name* name,
                             PropertyAttributes attributes,
                             int* out_insertion_index) {
   int transition = SearchName(name, out_insertion_index);
   if (transition == kNotFound) {
     return kNotFound;
   }
   return SearchDetails(transition, kind, attributes, out_insertion_index);
 }
 } }  // namespace v8::internal