Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 996133002: correctly invalidate global cells (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/double.h" 8 #include "src/double.h"
9 #include "src/factory.h" 9 #include "src/factory.h"
10 #include "src/hydrogen-infer-representation.h" 10 #include "src/hydrogen-infer-representation.h"
(...skipping 3614 matching lines...) Expand 10 before | Expand all | Expand 10 after
3625 3625
3626 3626
3627 std::ostream& HLoadGlobalCell::PrintDataTo(std::ostream& os) const { // NOLINT 3627 std::ostream& HLoadGlobalCell::PrintDataTo(std::ostream& os) const { // NOLINT
3628 os << "[" << *cell().handle() << "]"; 3628 os << "[" << *cell().handle() << "]";
3629 if (details_.IsConfigurable()) os << " (configurable)"; 3629 if (details_.IsConfigurable()) os << " (configurable)";
3630 if (details_.IsReadOnly()) os << " (read-only)"; 3630 if (details_.IsReadOnly()) os << " (read-only)";
3631 return os; 3631 return os;
3632 } 3632 }
3633 3633
3634 3634
3635 bool HLoadGlobalCell::RequiresHoleCheck() const {
3636 if (!details_.IsConfigurable()) return false;
3637 for (HUseIterator it(uses()); !it.Done(); it.Advance()) {
3638 HValue* use = it.value();
3639 if (!use->IsChange()) return true;
3640 }
3641 return false;
3642 }
3643
3644
3645 std::ostream& HLoadGlobalGeneric::PrintDataTo( 3635 std::ostream& HLoadGlobalGeneric::PrintDataTo(
3646 std::ostream& os) const { // NOLINT 3636 std::ostream& os) const { // NOLINT
3647 return os << name()->ToCString().get() << " "; 3637 return os << name()->ToCString().get() << " ";
3648 } 3638 }
3649 3639
3650 3640
3651 std::ostream& HInnerAllocatedObject::PrintDataTo( 3641 std::ostream& HInnerAllocatedObject::PrintDataTo(
3652 std::ostream& os) const { // NOLINT 3642 std::ostream& os) const { // NOLINT
3653 os << NameOf(base_object()) << " offset "; 3643 os << NameOf(base_object()) << " offset ";
3654 return offset()->PrintTo(os); 3644 return offset()->PrintTo(os);
(...skipping 1148 matching lines...) Expand 10 before | Expand all | Expand 10 after
4803 break; 4793 break;
4804 case HObjectAccess::kExternalMemory: 4794 case HObjectAccess::kExternalMemory:
4805 os << "[external-memory]"; 4795 os << "[external-memory]";
4806 break; 4796 break;
4807 } 4797 }
4808 4798
4809 return os << "@" << access.offset(); 4799 return os << "@" << access.offset();
4810 } 4800 }
4811 4801
4812 } } // namespace v8::internal 4802 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698