Chromium Code Reviews
DescriptionSky/Effen refactor: all nodes receive _mount/_unmount signal.
This patch refactors Effen in advance of allowing a final transform step from Effen nodes to sky nodes. The central changes here are:
1) Effen nodes get a _parentNode pointer
2) The lifetime of effen nodes is
->_sync (0 to N times)
-> the first _sync() causes a _mount()
->_unmount
3) Node should expect to sync even when they are first inserted (in which case they sync against a prototypical empty node which their class must provide).
4) Subclasses now override _syncNode() no longer takes host & insertBefore (_mount does). In the one case that a node must be replaced without being unmounted (inside _syncInternal), the old node is inspected for it's sky position.
TBR=abarth
Committed: https://chromium.googlesource.com/external/mojo/+/23cea7f0dfb1469d34afec2baa6d52ddb580e4da
Patch Set 1 #Patch Set 2 : cleanup #Patch Set 3 : moar #Patch Set 4 : sync #Patch Set 5 : a bit moar #
Total comments: 4
Messages
Total messages: 5 (1 generated)
|