pkg/compiler/lib/src/js/rewrite_async.dart - Issue 996103002: Fix handling of lazy and and or in async functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js/rewrite_async.dart

Issue 996103002: Fix handling of lazy and and or in async functions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Update unittest Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js/rewrite_async.dart

diff --git a/pkg/compiler/lib/src/js/rewrite_async.dart b/pkg/compiler/lib/src/js/rewrite_async.dart

index 8caf69f0af0303011f5d0434ff306f4c078cad2a..0f1f4333e250f7c5a3bef748e7cf310d08f67286 100644

--- a/pkg/compiler/lib/src/js/rewrite_async.dart

+++ b/pkg/compiler/lib/src/js/rewrite_async.dart

@@ -804,11 +804,11 @@ abstract class AsyncRewriterBase extends js.NodeVisitor {

js.Statement assignLeft = isResult(left)

? new js.Block.empty()

: js.js.statement('# = #;', [result, left]);

- if (node.op == "||") {

+ if (node.op == "&&") {

addStatement(js.js.statement('if (#) {#} else #',

[left, gotoAndBreak(thenLabel), assignLeft]));

} else {

- assert(node.op == "&&");

+ assert(node.op == "||");

addStatement(js.js.statement('if (#) {#} else #',

[left, assignLeft, gotoAndBreak(thenLabel)]));

}

« no previous file with comments | « no previous file | tests/compiler/dart2js/async_await_js_transform_test.dart » ('j') | tests/language/async_and_or_test.dart » ('J')