Handle empty strings properly in passphrase creation dialog.

Handle empty strings properly in passphrase creation dialog.

Previously this class would only possibly set the error message on
certain conditions (the confirm passphrase field had focus or text),
but would then incorrectly use the existence of that error as the
validation for the text.

Now those things are correctly decoupled. Additionally, the Ok button
will now pop up an error instead of closing the dialog if pressed when
the passphrases are invalid.

BUG=461071, 466095
Committed: https://crrev.com/d269e7375f6220b71223351b2cdb9fc616d78442
Cr-Commit-Position: refs/heads/master@{#320630}

[maxbogue, 2015-03-11 23:17:02]

maxbogue@chromium.org changed reviewers:
+ nyquist@chromium.org

[maxbogue, 2015-03-11 23:17:03]

PTAL! I'll rebase this on master once the upstream change rolls downstream.

[nyquist, 2015-03-14 00:03:29]

nyquist@chromium.org changed reviewers:
+ newt@chromium.org

[nyquist, 2015-03-14 00:03:30]

lgtm

newt: Any thoughts on whether it's possible to use a different approach for
ensuring that clicking the positive-button does not always dismiss the dialog
(in the case of an invalid passphrase)?

https://codereview.chromium.org/996073002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java
(right):

https://codereview.chromium.org/996073002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java:100:
.setPositiveButton(R.string.ok, null)
Is there a way to override the onClick, but still ensure that the dialog does
not close if the passphrase is not valid, other than changing the button
onClick-listener like you do below?

https://codereview.chromium.org/996073002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java:111:
// will close when the button is clickedregardless of what else we do.
Nit: "clicked regardless"

[newt (away), 2015-03-14 00:27:11]

https://codereview.chromium.org/996073002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java
(right):

https://codereview.chromium.org/996073002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java:100:
.setPositiveButton(R.string.ok, null)
On 2015/03/14 00:03:30, nyquist wrote:
> Is there a way to override the onClick, but still ensure that the dialog does
> not close if the passphrase is not valid, other than changing the button
> onClick-listener like you do below?

Sadly, nope. This is the standard way.

[maxbogue, 2015-03-14 01:07:37]

https://codereview.chromium.org/996073002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java
(right):

https://codereview.chromium.org/996073002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseCreationDialogFragment.java:111:
// will close when the button is clickedregardless of what else we do.
On 2015/03/14 at 00:03:30, nyquist wrote:
> Nit: "clicked regardless"

Done.

[maxbogue, 2015-03-14 01:07:44]

The CQ bit was checked by maxbogue@chromium.org

[maxbogue, 2015-03-14 01:07:44]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/996073002/#ps40001 (title:
"Add missing space in comment.")

[commit-bot: I haz the power, 2015-03-14 01:08:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996073002/40001

[commit-bot: I haz the power, 2015-03-14 01:45:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-14 01:45:45]

Patchset 3 (id:??) landed as
https://crrev.com/d269e7375f6220b71223351b2cdb9fc616d78442
Cr-Commit-Position: refs/heads/master@{#320630}