Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 996013006: Fixes typo of disabled tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/cancelable_callback.h" 6 #include "base/cancelable_callback.h"
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 } 752 }
753 753
754 // Tests that scripts are not duplicated after Scripts Panel switch. 754 // Tests that scripts are not duplicated after Scripts Panel switch.
755 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, 755 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest,
756 TestNoScriptDuplicatesOnPanelSwitch) { 756 TestNoScriptDuplicatesOnPanelSwitch) {
757 RunTest("testNoScriptDuplicatesOnPanelSwitch", kDebuggerTestPage); 757 RunTest("testNoScriptDuplicatesOnPanelSwitch", kDebuggerTestPage);
758 } 758 }
759 759
760 // Tests that debugger works correctly if pause event occurs when DevTools 760 // Tests that debugger works correctly if pause event occurs when DevTools
761 // frontend is being loaded. 761 // frontend is being loaded.
762 // Disabled because it fails on all trunk official build bots.
763 // http://crbug.com/467072
764 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, 762 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest,
765 DISABLED_TestPauseWhenLoadingDevTools) { 763 TestPauseWhenLoadingDevTools) {
766 RunTest("testPauseWhenLoadingDevTools", kPauseWhenLoadingDevTools); 764 RunTest("testPauseWhenLoadingDevTools", kPauseWhenLoadingDevTools);
767 } 765 }
768 766
769 // Tests that pressing 'Pause' will pause script execution if the script 767 // Tests that pressing 'Pause' will pause script execution if the script
770 // is already running. 768 // is already running.
771 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY) 769 // Disabled because it fails on all trunk official build bots.
770 // http://crbug.com/467072
771 // Previous condition:
772 // defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(ARCH_CPU_ARM_FAMILY)
772 // Timing out on linux ARM bot: https://crbug/238453 773 // Timing out on linux ARM bot: https://crbug/238453
773 #define MAYBE_TestPauseWhenScriptIsRunning DISABLED_TestPauseWhenScriptIsRunning 774 #define MAYBE_TestPauseWhenScriptIsRunning DISABLED_TestPauseWhenScriptIsRunning
774 #else
775 #define MAYBE_TestPauseWhenScriptIsRunning TestPauseWhenScriptIsRunning
776 #endif
777 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, 775 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest,
778 MAYBE_TestPauseWhenScriptIsRunning) { 776 MAYBE_TestPauseWhenScriptIsRunning) {
779 RunTest("testPauseWhenScriptIsRunning", kPauseWhenScriptIsRunning); 777 RunTest("testPauseWhenScriptIsRunning", kPauseWhenScriptIsRunning);
780 } 778 }
781 779
782 // Tests network timing. 780 // Tests network timing.
783 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestNetworkTiming) { 781 IN_PROC_BROWSER_TEST_F(DevToolsSanityTest, TestNetworkTiming) {
784 RunTest("testNetworkTiming", kSlowTestPage); 782 RunTest("testNetworkTiming", kSlowTestPage);
785 } 783 }
786 784
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 browser()->profile()->GetPrefs()->SetBoolean(prefs::kDevToolsDisabled, true); 961 browser()->profile()->GetPrefs()->SetBoolean(prefs::kDevToolsDisabled, true);
964 ui_test_utils::NavigateToURL(browser(), GURL("about:blank")); 962 ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
965 content::WebContents* web_contents = 963 content::WebContents* web_contents =
966 browser()->tab_strip_model()->GetWebContentsAt(0); 964 browser()->tab_strip_model()->GetWebContentsAt(0);
967 scoped_refptr<content::DevToolsAgentHost> agent( 965 scoped_refptr<content::DevToolsAgentHost> agent(
968 content::DevToolsAgentHost::GetOrCreateFor(web_contents)); 966 content::DevToolsAgentHost::GetOrCreateFor(web_contents));
969 DevToolsWindow::OpenDevToolsWindow(web_contents); 967 DevToolsWindow::OpenDevToolsWindow(web_contents);
970 DevToolsWindow* window = DevToolsWindow::FindDevToolsWindow(agent.get()); 968 DevToolsWindow* window = DevToolsWindow::FindDevToolsWindow(agent.get());
971 ASSERT_FALSE(window); 969 ASSERT_FALSE(window);
972 } 970 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698