Adds a command-line option that disables AeroPeek....

Adds a command-line option that disables AeroPeek.
This change adds a command-line option "--disable-aeropeek" that disables our custom AeroPeek implementation. Also, we disable AeroPeek when Aero is disabled because AeroPeek functions return errors.

BUG=37957
TEST=launch chrome with --disable-aeropeek option.
TEST=launch chrome on the "Windows 7 Basic" theme.

[Hironori Bono, 2010-03-19 05:05:23]

Ben,

I have added a command-line option to disable our custom AeroPeek implementation
because more people (than I expected) don't like it. Thank you for your review
in advance.

Regards,

Hironori Bono

[Peter Kasting, 2010-03-21 01:54:29]

I don't think we should add this option.
* It's obscure, so lots of ticked-off people won't find it, and will remain
ticked-off.
* We're going to remove it eventually when we have settled on our final design,
and when we do, the people who turned it on will be really infuriated.
* We need people testing the real solutions we come up with.

I'm also not sure you should use ShouldUseVistaFrame() to check if Aero is on,
because I think that will return false if a user uses a custom theme.

[Ben Goodger (Google), 2010-03-23 17:00:14]

Agree. We are currently discussing ways to improve this. We don't
believe that adding an option to disable it is likely sufficient.

-Ben

On Sat, Mar 20, 2010 at 6:54 PM,  <pkasting@chromium.org> wrote:
> I don't think we should add this option.
> * It's obscure, so lots of ticked-off people won't find it, and will remain
> ticked-off.
> * We're going to remove it eventually when we have settled on our final
> design,
> and when we do, the people who turned it on will be really infuriated.
> * We need people testing the real solutions we come up with.
>
> I'm also not sure you should use ShouldUseVistaFrame() to check if Aero is
> on,
> because I think that will return false if a user uses a custom theme.
>
> http://codereview.chromium.org/996003
>

[Hironori Bono, 2010-03-24 01:32:07]

Thank you for your comments.
I agree. It is better to improve AeroPeek than to disable it. I close this
change to implement your suggestions. :)

Regards,

Hironori Bono