Issue 9960002: Make all the things use cert_test_util.h.

Issue 9960002: Make all the things use cert_test_util.h. (Closed)

Created:
8 years, 8 months ago by mattm

Modified:
8 years, 8 months ago

Reviewers:
Sergey Ulanov, Ryan Sleevi

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make all the things use cert_test_util.h. BUG=none TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130018

Patch Set 1 #

Total comments: 2

Patch Set 2 : nitfix #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -114 lines)			Patch
M	chrome/common/net/x509_certificate_model_unittest.cc	View	1	2 chunks	+21 lines, -49 lines	0 comments	Download
M	net/base/cert_database_nss_unittest.cc	View		9 chunks	+22 lines, -47 lines	0 comments	Download
M	net/socket/ssl_server_socket_unittest.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	remoting/protocol/authenticator_test_base.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	remoting/remoting.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

Woo! Thanks for doing this. LGTM. http://codereview.chromium.org/9960002/diff/1/chrome/common/net/x509_certificate_model_unittest.cc File chrome/common/net/x509_certificate_model_unittest.cc (right): http://codereview.chromium.org/9960002/diff/1/chrome/common/net/x509_certificate_model_unittest.cc#newcode18 chrome/common/net/x509_certificate_model_unittest.cc:18: ASSERT_TRUE(cert.get() != NULL); ...

8 years, 8 months ago (2012-03-30 01:14:49 UTC) #2

mattm

+sergeyu for remoting/OWNERS http://codereview.chromium.org/9960002/diff/1/chrome/common/net/x509_certificate_model_unittest.cc File chrome/common/net/x509_certificate_model_unittest.cc (right): http://codereview.chromium.org/9960002/diff/1/chrome/common/net/x509_certificate_model_unittest.cc#newcode18 chrome/common/net/x509_certificate_model_unittest.cc:18: ASSERT_TRUE(cert.get() != NULL); On 2012/03/30 01:14:49, ...

8 years, 8 months ago (2012-03-30 01:24:17 UTC) #3

lgtm

Expand Messages | Collapse Messages