chrome/browser/ui/cocoa/extensions/extension_view_mac.mm - Issue 995983002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

Issue 995983002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: roll back some stuff Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm ('k') | chrome/browser/ui/views/extensions/extension_popup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm b/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

index 7b62cfc680e4c7fadc805fa5b67af7094eed13af..c45987971af621eb935224c1bd12bd5f0bfed36d 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

@@ -93,7 +93,7 @@ content::RenderViewHost* ExtensionViewMac::render_view_host() const {

void ExtensionViewMac::ShowIfCompletelyLoaded() {

// We wait to show the ExtensionView until it has loaded, and the view has

// actually been created. These can happen in different orders.

- if (extension_host_->did_stop_loading()) {

+ if (extension_host_->has_loaded_once()) {

[GetNativeView() setHidden:NO];

if (container_)

container_->OnExtensionViewDidShow(this);