chrome/browser/extensions/extension_view_host.cc - Issue 995983002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_view_host.cc

Issue 995983002: Make LoadMonitoringExtensionHostQueue remove itself as an ExtensionHost observer at the correct tim… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: aha Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_view_host.cc

diff --git a/chrome/browser/extensions/extension_view_host.cc b/chrome/browser/extensions/extension_view_host.cc

index 1d0ef9cfbf0982b1701585bd0e624751c1f584da..aa98de68fa546c3c23c0b2f04b230a93d69ca4f7 100644

--- a/chrome/browser/extensions/extension_view_host.cc

+++ b/chrome/browser/extensions/extension_view_host.cc

@@ -99,7 +99,7 @@ void ExtensionViewHost::UnhandledKeyboardEvent(

// ExtensionHost overrides:

void ExtensionViewHost::OnDidStopLoading() {

- DCHECK(did_stop_loading());

+ DCHECK(has_loaded_once());

Yoyo Zhou 2015/03/12 22:57:29 Should this be is_loading? (I mean, it's okay as i

not at google - send to devlin 2015/03/12 23:29:22 Yeah, it correlates with is_loading (though perhap

view_->DidStopLoading();

}

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm » ('j') | extensions/browser/extension_host.cc » ('J')