Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 995863002: Revert of Adjust distance field glyph and font atlas sizes to maximize storage. (Closed)

Created:
5 years, 9 months ago by jvanverth1
Modified:
5 years, 9 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Adjust distance field glyph and font atlas sizes to maximize storage. (patchset #8 id:140001 of https://codereview.chromium.org/986343002/) Reason for revert: Still seeing bad text rendering in GMs with Nexus 2 and Nexus 3. Original issue's description: > Adjust distance field glyph and font atlas sizes to maximize storage. > > Because of high DPI devices, we need more room in the glyph > atlas for the larger glyphs. These settings will allow 4 of > the distance field glyphs to fit in one Plot (increasing > the storage from 32 large glyphs to 128), and still permit > us to handle glyphs up to a 312 point size. > > BUG=chromium:458791 > > Committed: https://skia.googlesource.com/skia/+/d2737ad7dd8f4ea94a74034027014fd3d78923cb > > Committed: https://skia.googlesource.com/skia/+/07e245ffe1ca7f781590fcff904c2922c2269781 TBR=joshualitt@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:458791 Committed: https://skia.googlesource.com/skia/+/c41df8d92d885ecb71af7795b22ebc7417187f61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M src/gpu/GrFontAtlasSizes.h View 1 chunk +9 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvanverth1
Created Revert of Adjust distance field glyph and font atlas sizes to maximize storage.
5 years, 9 months ago (2015-03-10 15:22:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995863002/1
5 years, 9 months ago (2015-03-10 15:23:03 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:23:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c41df8d92d885ecb71af7795b22ebc7417187f61

Powered by Google App Engine
This is Rietveld 408576698