Chromium Code Reviews
DescriptionDisable NavigateRemoteFrameToBlankAndDataURLs on Windows.
It has been flaky on Win8 Aura bots (https://build.chromium.org/p/chromium.win/builders/Win8%20Aura?numbuilds=200) ever since it was introduced in r319567.
Example failure log:
SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs (run #1):
[ RUN ] SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs
Backtrace:
`anonymous namespace'::InvalidParameter [0x058B8A74+4]
invalid_parameter [0x750DA856+54]
std::vector\u003Ccontent::FrameTreeNode *,std::allocator\u003Ccontent::FrameTreeNode *> >::operator[] [0x036462AC+156]
ScopedVector\u003Ccontent::FrameTreeNode>::operator[] [0x036461EA+26]
content::FrameTreeNode::child_at [0x036494C0+32]
content::SitePerProcessBrowserTest_NavigateRemoteFrameToBlankAndDataURLs_Test::RunTestOnMainThread [0x006B446E+4094]
content::ContentBrowserTest::RunTestOnMainThreadLoop [0x0082330C+364]
content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x008A7832+354]
base::internal::RunnableAdapter\u003Cvoid (__thiscall content::BrowserTestBase::*)(void)>::Run [0x008A7F8B+27]
base::internal::InvokeHelper\u003C0,void,base::internal::RunnableAdapter\u003Cvoid (__thiscall content::BrowserTestBase::*)(void)>,base::internal::TypeList\u003Ccontent::BrowserTestBase * const &> >::MakeItSo [0x008A73EA+26]
base::internal::Invoker\u003CIndexSequence\u003C0>,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid (__thiscall content::BrowserTestBase::*)(void)>,void __cdecl(content::BrowserTestBase *),base::internal::TypeList\u003Ccontent::BrowserTestBase *> >,base::i [0x008A7EB6+54]
base::Callback\u003Cvoid __cdecl(void)>::Run [0x004E9EAF+47]
content::ShellBrowserMainParts::PreMainMessageLoopRun [0x0084AE38+264]
content::BrowserMainLoop::PreMainMessageLoopRun [0x03866A29+249]
base::internal::RunnableAdapter\u003Cint (__thiscall content::BrowserMainLoop::*)(void)>::Run [0x0386715B+27]
base::internal::InvokeHelper\u003C0,int,base::internal::RunnableAdapter\u003Cint (__thiscall content::BrowserMainLoop::*)(void)>,base::internal::TypeList\u003Ccontent::BrowserMainLoop *> >::MakeItSo [0x0386629A+26]
base::internal::Invoker\u003CIndexSequence\u003C0>,base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cint (__thiscall content::BrowserMainLoop::*)(void)>,int __cdecl(content::BrowserMainLoop *),base::internal::TypeList\u003Cbase::internal::UnretainedWrapper\u003Cconte [0x03866F98+56]
base::Callback\u003Cint __cdecl(void)>::Run [0x03FC2DCF+47]
content::StartupTaskRunner::RunAllTasksNow [0x044EFEFE+126]
content::BrowserMainLoop::CreateStartupTasks [0x03861FE1+705]
content::BrowserMainRunnerImpl::Initialize [0x0386FAC0+720]
ShellBrowserMain [0x00A49654+68]
content::ShellMainDelegate::RunProcess [0x00A4513F+223]
content::RunNamedProcessTypeMain [0x035F26AF+127]
content::ContentMainRunnerImpl::Run [0x035F24F2+578]
content::ContentMain [0x035DE940+144]
content::BrowserTestBase::SetUp [0x008A85D8+1448]
content::ContentBrowserTest::SetUp [0x0082346C+140]
testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::Test,void> [0x00972057+55]
testing::Test::Run [0x0098FE2B+107]
testing::TestInfo::Run [0x0099010D+221]
testing::TestCase::Run [0x0098FFAF+239]
testing::internal::UnitTestImpl::RunAllTests [0x009905E6+726]
testing::internal::HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl,bool> [0x00972147+55]
testing::UnitTest::Run [0x0099029B+267]
RUN_ALL_TESTS [0x00B10A6F+15]
base::TestSuite::Run [0x00B10C33+179]
content::ContentTestLauncherDelegate::RunTestSuite [0x00A4309C+60]
content::LaunchTests [0x008BB407+967]
main [0x00A43141+113]
__tmainCRTStartup [0x00A40CA9+409] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:626)
mainCRTStartup [0x00A40DED+13] (f:\dd\vctools\crt\crtw32\dllstuff\crtexe.c:466)
BaseThreadInitThunk [0x76D1495D+14]
RtlInitializeExceptionChain [0x77E898EE+132]
RtlInitializeExceptionChain [0x77E898C4+90]
TBR=lfg, nasko
BUG=446575
Committed: https://crrev.com/a6038c8bc8770a579b66da5517d26efb3565b1f9
Cr-Commit-Position: refs/heads/master@{#319887}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||