Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 99583004: Try another GYP DEPS (Closed)

Created:
7 years ago by borenet
Modified:
6 years, 11 months ago
Reviewers:
rmistry, robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Try another GYP DEPS This one is just before the introduction of the Python 2.7 requirement. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12651

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Add SkPreConfig.h to core.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/core.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
7 years ago (2013-12-12 20:07:02 UTC) #1
robertphillips
lgtm
7 years ago (2013-12-12 20:41:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/99583004/1
7 years ago (2013-12-12 20:42:22 UTC) #3
commit-bot: I haz the power
Failed to apply patch for DEPS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-12 20:42:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/99583004/20001
7 years ago (2013-12-12 20:47:09 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-12 20:55:08 UTC) #6
Message was sent while issue was closed. 
Change committed as 12651

Powered by Google App Engine
This is Rietveld 408576698