Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 995813002: CpuProfiler: slightly reduce the size of JumpTable code on arm64. (Closed)

Created:
5 years, 9 months ago by loislo
Modified:
5 years, 9 months ago
Reviewers:
Sven Panne, jbramley, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

CpuProfiler: slightly reduce the size of JumpTable code on arm64. BUG=chromium:452067 LOG=n R=svenpanne@chromium.org, jacob.bramley@arm.com, yurys@chromium.org Committed: https://crrev.com/0fcebccd7e78bf90b09e4856ebd75aa1eaf4194a Cr-Commit-Position: refs/heads/master@{#27112}

Patch Set 1 #

Patch Set 2 : minor fix #

Patch Set 3 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
loislo
PTAL
5 years, 9 months ago (2015-03-10 14:11:04 UTC) #1
jbramley
lgtm
5 years, 9 months ago (2015-03-10 14:48:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995813002/40001
5 years, 9 months ago (2015-03-10 14:51:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1105)
5 years, 9 months ago (2015-03-10 15:00:25 UTC) #6
Sven Panne
lgtm
5 years, 9 months ago (2015-03-10 15:01:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995813002/40001
5 years, 9 months ago (2015-03-10 15:02:04 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-10 15:12:58 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:13:16 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0fcebccd7e78bf90b09e4856ebd75aa1eaf4194a
Cr-Commit-Position: refs/heads/master@{#27112}

Powered by Google App Engine
This is Rietveld 408576698