Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 995783002: Gracefully handle mixed content checking on detached resource fetches. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
Nate Chapin, Mike West
CC:
blink-reviews, tyoshino+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, darktears, Nate Chapin, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Gracefully handle mixed content checking on detached resource fetches. Do not assume the presence of a frame() when performing the mixed content checks in ResourceFetcher::canRequest(). R=mkwst@chromium.org BUG=461225 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
A + LayoutTests/fast/xmlhttprequest/xmlhttprequest-detached-mixedcontent-no-crash.html View 1 chunk +5 lines, -4 lines 0 comments Download
A + LayoutTests/fast/xmlhttprequest/xmlhttprequest-detached-mixedcontent-no-crash-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontFaceSrcValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 4 chunks +9 lines, -5 lines 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. Took the liberty of doing some IWYU tidying at the same ...
5 years, 9 months ago (2015-03-10 13:11:59 UTC) #2
Mike West
LGTM. Thank you for this fix!
5 years, 9 months ago (2015-03-10 15:39:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995783002/1
5 years, 9 months ago (2015-03-10 15:41:22 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:44:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191636

Powered by Google App Engine
This is Rietveld 408576698