Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 995773002: Add testRunner.dumpNavigationPolicy() to be able to the the navigation policy (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
Reviewers:
Mike West, Rick Byers
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add testRunner.dumpNavigationPolicy() to be able to the the navigation policy Since content_shell doesn't support tabs, we can't otherwise tell apart background tabs from foreground tabs in layout tests. BUG=454222 R=mkwst@chromium.org,rbyers@chromium.org Committed: https://crrev.com/c3a98da19b1c732ae1313f1c8f6c17186be604fa Cr-Commit-Position: refs/heads/master@{#319873}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M content/shell/renderer/test_runner/test_runner.h View 3 chunks +9 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 6 chunks +17 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-10 12:54:38 UTC) #1
jochen (gone - plz use gerrit)
ptal
5 years, 9 months ago (2015-03-10 12:56:13 UTC) #2
Mike West
LGTM.
5 years, 9 months ago (2015-03-10 13:09:22 UTC) #3
Mike West
https://codereview.chromium.org/995773002/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (right): https://codereview.chromium.org/995773002/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc#newcode1326 content/shell/renderer/test_runner/web_test_proxy.cc:1326: URLDescription(info.urlRequest.url()) + " is '" + Nit: If you ...
5 years, 9 months ago (2015-03-10 13:10:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995773002/20001
5 years, 9 months ago (2015-03-10 13:18:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-10 14:00:09 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 14:00:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c3a98da19b1c732ae1313f1c8f6c17186be604fa
Cr-Commit-Position: refs/heads/master@{#319873}

Powered by Google App Engine
This is Rietveld 408576698