Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 995763004: kiosk: Fix bailout shortcut not working. (Closed)

Created:
5 years, 9 months ago by xiyuan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

kiosk: Fix bailout shortcut not working. Explicitly enable login display before launching kiosk so that the bailout shortcut key works. BUG=465561 Committed: https://crrev.com/390c1768aa44713198ed393271d985ba2c628263 Cr-Commit-Position: refs/heads/master@{#320088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xiyuan
5 years, 9 months ago (2015-03-10 19:37:54 UTC) #2
Denis Kuznetsov (DE-MUC)
lgtm
5 years, 9 months ago (2015-03-11 11:22:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995763004/1
5 years, 9 months ago (2015-03-11 15:20:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 15:26:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/390c1768aa44713198ed393271d985ba2c628263 Cr-Commit-Position: refs/heads/master@{#320088}
5 years, 9 months ago (2015-03-11 15:26:49 UTC) #7
xiyuan
5 years, 9 months ago (2015-03-11 17:46:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/999143002/ by xiyuan@chromium.org.

The reason for reverting is: Multiple KioskTest becomes flaky after the CL
lands. Revert and investigate..

Powered by Google App Engine
This is Rietveld 408576698