Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 995753002: Load webview based GAIA in hidden state and pass focus when ready (Closed)

Created:
5 years, 9 months ago by Dmitry Polukhin
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Load webview based GAIA in hidden state and pass focus when ready This patch re-enabled GAIA preloading, removes 'focusready' message per agreement and add focus passing logic. BUG=462337 TEST=manual Committed: https://crrev.com/588c2d98ad0f1f4f29d6b93ad37ea5060f297477 Cr-Commit-Position: refs/heads/master@{#319893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -42 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 7 chunks +7 lines, -20 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 2 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dmitry Polukhin
PTAL
5 years, 9 months ago (2015-03-10 12:23:03 UTC) #2
Nikita (slow)
Please also reference 456118
5 years, 9 months ago (2015-03-10 12:43:18 UTC) #3
Nikita (slow)
lgtm
5 years, 9 months ago (2015-03-10 12:45:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/995753002/1
5 years, 9 months ago (2015-03-10 14:32:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 16:04:27 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 16:05:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/588c2d98ad0f1f4f29d6b93ad37ea5060f297477
Cr-Commit-Position: refs/heads/master@{#319893}

Powered by Google App Engine
This is Rietveld 408576698