Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 99573004: rename StrokeRect to StrokeRects (Closed)

Created:
7 years ago by yunchao
Modified:
7 years ago
Reviewers:
bungeman-skia, reed1
CC:
skia-review_googlegroups.com, hcm
Visibility:
Public.

Description

Just a typo. Rename StrokeRect to StrokeRects in strokerects.cpp, making it different from the class name in strokerect.cpp for debugging. Committed: http://code.google.com/p/skia/source/detail?r=12557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M gm/strokerects.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yunchao
7 years ago (2013-12-06 06:17:26 UTC) #1
reed1
7 years ago (2013-12-06 14:24:34 UTC) #2
yunchao
On 2013/12/06 14:24:34, reed1 wrote: Hey Mike, thanks for your reply. Do you have any ...
7 years ago (2013-12-06 17:07:37 UTC) #3
reed1
lgtm I'm not sure it is really worth much time to fix these, unless its ...
7 years ago (2013-12-06 17:16:08 UTC) #4
yunchao
On 2013/12/06 17:16:08, reed1 wrote: > lgtm > > I'm not sure it is really ...
7 years ago (2013-12-09 09:06:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/99573004/1
7 years ago (2013-12-09 09:06:47 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-09 09:15:01 UTC) #7
Message was sent while issue was closed.
Change committed as 12557

Powered by Google App Engine
This is Rietveld 408576698