OLD | NEW |
1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
2 # Copyright 2013 the V8 project authors. All rights reserved. | 2 # Copyright 2013 the V8 project authors. All rights reserved. |
3 # Redistribution and use in source and binary forms, with or without | 3 # Redistribution and use in source and binary forms, with or without |
4 # modification, are permitted provided that the following conditions are | 4 # modification, are permitted provided that the following conditions are |
5 # met: | 5 # met: |
6 # | 6 # |
7 # * Redistributions of source code must retain the above copyright | 7 # * Redistributions of source code must retain the above copyright |
8 # notice, this list of conditions and the following disclaimer. | 8 # notice, this list of conditions and the following disclaimer. |
9 # * Redistributions in binary form must reproduce the above | 9 # * Redistributions in binary form must reproduce the above |
10 # copyright notice, this list of conditions and the following | 10 # copyright notice, this list of conditions and the following |
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
96 "Title text 3\n\nBUG=1234\nLOG = Yes\n", | 96 "Title text 3\n\nBUG=1234\nLOG = Yes\n", |
97 "author3@chromium.org"], | 97 "author3@chromium.org"], |
98 ["Title text 3", | 98 ["Title text 3", |
99 "Title text 4\n\nBUG=1234\nLOG=\n", | 99 "Title text 4\n\nBUG=1234\nLOG=\n", |
100 "author4@chromium.org"], | 100 "author4@chromium.org"], |
101 ] | 101 ] |
102 self.assertEquals(" Title text 1.\n\n" | 102 self.assertEquals(" Title text 1.\n\n" |
103 " Title text 3 (Chromium issue 1234).\n\n", | 103 " Title text 3 (Chromium issue 1234).\n\n", |
104 MakeChangeLogBody(commits, True)) | 104 MakeChangeLogBody(commits, True)) |
105 | 105 |
| 106 def testRegressWrongLogEntryOnTrue(self): |
| 107 body = """ |
| 108 Check elimination: Learn from if(CompareMap(x)) on true branch. |
| 109 |
| 110 BUG= |
| 111 R=verwaest@chromium.org |
| 112 |
| 113 Committed: https://code.google.com/p/v8/source/detail?r=18210 |
| 114 """ |
| 115 self.assertEquals("", MakeChangeLogBody([["title", body, "author"]], True)) |
| 116 |
106 def testMakeChangeLogBugReferenceEmpty(self): | 117 def testMakeChangeLogBugReferenceEmpty(self): |
107 self.assertEquals("", MakeChangeLogBugReference("")) | 118 self.assertEquals("", MakeChangeLogBugReference("")) |
108 self.assertEquals("", MakeChangeLogBugReference("LOG=")) | 119 self.assertEquals("", MakeChangeLogBugReference("LOG=")) |
109 self.assertEquals("", MakeChangeLogBugReference(" BUG =")) | 120 self.assertEquals("", MakeChangeLogBugReference(" BUG =")) |
110 self.assertEquals("", MakeChangeLogBugReference("BUG=none\t")) | 121 self.assertEquals("", MakeChangeLogBugReference("BUG=none\t")) |
111 | 122 |
112 def testMakeChangeLogBugReferenceSimple(self): | 123 def testMakeChangeLogBugReferenceSimple(self): |
113 self.assertEquals("(issue 987654)", | 124 self.assertEquals("(issue 987654)", |
114 MakeChangeLogBugReference("BUG = v8:987654")) | 125 MakeChangeLogBugReference("BUG = v8:987654")) |
115 self.assertEquals("(Chromium issue 987654)", | 126 self.assertEquals("(Chromium issue 987654)", |
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
721 | 732 |
722 Review URL: https://codereview.chromium.org/83173002 | 733 Review URL: https://codereview.chromium.org/83173002 |
723 | 734 |
724 ------------------------------------------------------------------------""") | 735 ------------------------------------------------------------------------""") |
725 self.assertEquals( | 736 self.assertEquals( |
726 """Prepare push to trunk. Now working on version 3.23.11. | 737 """Prepare push to trunk. Now working on version 3.23.11. |
727 | 738 |
728 R=danno@chromium.org | 739 R=danno@chromium.org |
729 | 740 |
730 Committed: https://code.google.com/p/v8/source/detail?r=17997""", body) | 741 Committed: https://code.google.com/p/v8/source/detail?r=17997""", body) |
OLD | NEW |