Issue 99573003: Fix change log generation in push-to-trunk script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99573003: Fix change log generation in push-to-trunk script. (Closed)

Created:
7 years ago by Michael Achenbach

Modified:
7 years ago

Reviewers:
ulan

CC:
v8-dev, Jakob Kummerow

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix change log generation in push-to-trunk script. Fixed missing parenthesis in regular expression. The log checker matched on the word "true" and included a wrong change log entry. TEST=python -m unittest test_scripts.ToplevelTest.testRegressWrongLogEntryOnTrue R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18220

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	tools/push-to-trunk/common_includes.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/push-to-trunk/test_scripts.py	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

7 years ago (2013-12-03 09:13:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18220 (presubmit successful).

Expand Messages | Collapse Messages